Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVM: Add support for token split via DST20 v2 contract #2903

Merged
merged 12 commits into from
Apr 29, 2024

Conversation

Jouzo
Copy link
Collaborator

@Jouzo Jouzo commented Apr 22, 2024

Summary

  • Introduces new DST20 v2 contract which updates the EVM token split mechanism such as :

    • Removes the need for intrinsic v2
    • Upgrades the DST20 contract to implement ITokenSplit interface which contains both SplitResult event and split method
    • Injects the new amount on the old contract instead of the message sender, which lets us send the token from the old contract to the message sender.
    • Goes through the DST20(newContract).transfer method to trigger a transfer event. This should now be correctly picked up by blockscout as a token transfer from the old contract to the message sender of the new amount of the new token
  • Deploy new DST20 version on fork height df23 by updating the implementation slot

  • Clean up of DST20 contract free functions in dedicated file and introduce contract directory

@Jouzo
Copy link
Collaborator Author

Jouzo commented Apr 23, 2024

Home tab:
Screenshot 2024-04-23 at 14 55 53

TX detail tab:
Screenshot 2024-04-23 at 14 55 58

Log tab:
Screenshot 2024-04-23 at 14 56 09

Function call tab:
Screenshot 2024-04-23 at 14 56 03

State changes tab:
Screenshot 2024-04-23 at 14 56 13

@prasannavl prasannavl merged commit d163c54 into master Apr 29, 2024
22 of 26 checks passed
@prasannavl prasannavl deleted the feature/dst20_v2 branch April 29, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants