Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[breaking] Simplify UpdateTip log entry #2937

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Conversation

Bushstar
Copy link
Member

@Bushstar Bushstar commented Jun 12, 2024

Summary

  • Simplify the overly verbose UpdateTip log entry to the following.
UpdateTip: height=4062963 hash=ed6ddcc70f13e798afa14a4529162a077bc56c740980f2b1d92cbc71d3bdf792 progress=1.000000 tx=32104696 date='2024-06-12T09:50:51Z'

Implications

  • Storage

    • Database reindex required
    • Database reindex optional
    • Database reindex not required
    • None
  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

@Jouzo
Copy link
Collaborator

Jouzo commented Jun 12, 2024

Should we use this PR to add EVM block height as well ?

@Bushstar
Copy link
Member Author

Should we use this PR to add EVM block height as well ?

Sure. Feel free to use this PR.

@Bushstar Bushstar changed the title Simplify UpdateTip log entry [breaking] Simplify UpdateTip log entry Jun 12, 2024
@prasannavl
Copy link
Member

Note that this is small enough to reduce noise and makes logs more useful at the same time not break compatibility too much that's it's harder for using parsers related to bitcoin to adapt.

Leaving the rationale for the breaking change:

  • Remove longstanding noise, that's not very useful, but has been inherited from BTC
    • version: Not very useful for us to print on each line.
    • cache: Not accurate as it isn't an accurate repr of any actual usage in our chain as we have several caches that's spread across many things.
  • Moving height to the first parameter, as that's the most useful info that's currently sandwiched in between many things.
  • Removing superfluous words and labeling hash.

Could use significant changes, but anything else would break log parsers completely.

@prasannavl prasannavl merged commit bedff8a into master Jun 12, 2024
23 of 26 checks passed
@prasannavl prasannavl deleted the bush/updatetip-log branch June 12, 2024 11:02
@prasannavl
Copy link
Member

Further: #2939

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants