Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: Add TokenAmount abstraction #2951

Merged
merged 10 commits into from
Jun 28, 2024
Merged

tests: Add TokenAmount abstraction #2951

merged 10 commits into from
Jun 28, 2024

Conversation

prasannavl
Copy link
Member

@prasannavl prasannavl commented Jun 27, 2024 •
edited
Loading

Summary

  • Make token amount easier to use in tests and simplify the amount of noisy concatenated strings in tests that results in harder to follow tests and add higher impedance to tests

Implications

  • Storage

    • Database reindex required
    • Database reindex optional
    • Database reindex not required
    • None

  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

@Bushstar
Copy link
Member

TokenAmount should also have a def __eq__(self, other) method.

@prasannavl
Copy link
Member Author

prasannavl commented Jun 28, 2024 •
edited
Loading

Done, good call, missed

@Bushstar Bushstar merged commit 0987105 into master Jun 28, 2024
24 of 26 checks passed
@Bushstar Bushstar deleted the pvl/tests-tokenam branch June 28, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prasannavl @Bushstar