Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update account history for static rewards. Fix off by one bug. #3018

Merged
merged 1 commit into from
Sep 1, 2024
Merged

Update account history for static rewards. Fix off by one bug. #3018

merged 1 commit into from
Sep 1, 2024

Conversation

Bushstar
Copy link
Member

Summary

  • Update listaccounthistory for static rewards
  • Fix off by one bug in static rewards
  • Set onReward height to key height, only used in account history and then shows the correct height, otherwise also off by one.

Implications

  • Storage

    • Database reindex required
    • Database reindex optional
    • Database reindex not required
    • None

  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

@prasannavl prasannavl merged commit b0a0b0f into master Sep 1, 2024
19 of 26 checks passed
@prasannavl prasannavl deleted the bush/static-history branch September 1, 2024 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bushstar @prasannavl