Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miner: Check loan tokens are not locked before adding dToken restart #3048

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

Bushstar
Copy link
Member

Summary

  • dToken restart will fail if any loan tokens are locked, this will result in a block hash mismatch as the miner will have added the expected token creation TXs and EVM TXs for the restart. This PR adds code to the miner to skip adding these TXs if there are locked loan tokens avoiding creating invalid blocks.

Implications

  • Storage

    • Database reindex required
    • Database reindex optional
    • Database reindex not required
    • None
  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

@prasannavl prasannavl merged commit a0ac5bc into master Sep 16, 2024
16 of 26 checks passed
@prasannavl prasannavl deleted the bush/restart-check-locks branch September 16, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants