Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of PR is this?:
/kind feature
What this PR does / why we need it:
This adds native support for CORS for the RPC API.
This enables the following:
Details
This adds the following flags to defid:
When the defid is executed with, for instance:
defid -rpcallowcors=http://127.0.0.1:5000
This PR adds CORS support that's needed by modern browsers to allow the specific origin to communicate with node directly.
Note: Using wildcards for Origin
*
is NOT supported, since this also sets up theAllow-Credentials
flag that according to RFC requires that the the origin is explicit.This enables scenarios like BirthdayResearch/defichain-app#766 natively with defichain without the need for proxies that often complicates end to end security.
Example: