Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test Certification #67

Merged
merged 7 commits into from
Dec 17, 2019
Merged

Add test Certification #67

merged 7 commits into from
Dec 17, 2019

Conversation

thuyvy3110
Copy link
Collaborator

@thuyvy3110 thuyvy3110 commented Dec 16, 2019

Add test certification & snapshot

@vercel
Copy link

vercel bot commented Dec 16, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/monkeybear/phatho-porfolio-nextjs/58y40jkzo
🌍 Preview: https://phatho-porfolio-nextjs-git-add-certification.monkeybear.now.sh

@thuyvy3110 thuyvy3110 self-assigned this Dec 16, 2019
@thuyvy3110 thuyvy3110 added the enhancement New feature or request label Dec 16, 2019
@DeKal DeKal self-requested a review December 16, 2019 08:35
Copy link
Owner

@DeKal DeKal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a line 19 in Cert.js is not covered, it's ok, but good to fix tho

import { mountWithTheme } from '~/utils/withThemeProviders'
import Certification from '~/views/components/Certification'

describe('About', () => {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Certification -> fix and gen snapshot

@DeKal DeKal merged commit c4199db into master Dec 17, 2019
@DeKal DeKal deleted the add-certification branch December 17, 2019 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants