Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random seeds value #13

Closed
hamanhbui opened this issue Nov 11, 2020 · 5 comments
Closed

Random seeds value #13

hamanhbui opened this issue Nov 11, 2020 · 5 comments

Comments

@hamanhbui
Copy link

Dear authors, thank you for your supporting code for DG, it could be a good baseline for us to expand a new idea.
However, I have a question about your reported results. I am seeing your code have set "torch.manual_seed(0) torch.cuda.manual_seed(0)", this means that you fix seeds for your CUDA, but your papers said that you ran on 5 different times (I understand here is with different seeds for CUDA) then get the average.
I am asking this question because if removing 2 of those lines, I can not reproduce your results, especially when tuning on validation set (only around 81.2% accuracy). Could you please explain this problem?

Looking forward to your answer, thanks.

@Justinhzy
Copy link
Collaborator

Hi,
Thanks for your question.
I fix the random seed and code wrt probabilities for PACS experiments for 5 runs.
Do you mean changing 5 different random seeds and get the average?

@hamanhbui
Copy link
Author

Yes, It is exactly what I mean.

@SirRob1997
Copy link

SirRob1997 commented Nov 15, 2020

@hamanhbui has been mentioned before, results seem to be non-reproducible see #12 #2 #5

@hamanhbui
Copy link
Author

Many thanks for your suggestion @SirRob1997

@DeLightCMU DeLightCMU deleted a comment from SirRob1997 Nov 18, 2020
@Justinhzy
Copy link
Collaborator

Hi,
Sorry for the late reply. I've been a little busy lately.
Please see my updated notice. Generally speaking, most DG datasets are small, you may need to turn the parameter for your environment, including random seed. Though it is not ideal, you may get a higher baseline to start with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants