Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental results in paper #14

Open
VuongLong opened this issue Nov 12, 2020 · 4 comments
Open

Experimental results in paper #14

VuongLong opened this issue Nov 12, 2020 · 4 comments

Comments

@VuongLong
Copy link

Dear authors, thank you for work,
I run your implementation and got lower results than ones reported in the paper. I have some questions:

  1. Your results reported in the paper (average ~85.15) is selected by test-set?

  2. I got average results from your implementation:

  • selected by validation-set ~ 83.37
  • selected by test-set ~ 84.25
  1. when I turn off your seed configs and try 5 runs with random seed?
  • selected by validation-set ~ 82.63
  • selected by test-set ~ 83.81

Thank you for your contribution!

@SirRob1997
Copy link

SirRob1997 commented Nov 15, 2020

A common problem here, see #12 #13 #2 #5

@Justinhzy
Copy link
Collaborator

Justinhzy commented Nov 19, 2020

Hi,
Thanks for your reported issue.

Indeed, closing the seed config will change the results. In experiments, however, this can change results so much that it is hard to select the parameters. So I fix the random seed. I am not sure if fixing random seed is common or not in DG task, but it is common in other tasks. If you want to close the seed configs, please see my updated notice which may be useful for you.

Yes, I reported the results selected by val-set. You can see my training logs in the testing section.

@gshuangchun
Copy link

Dear authors, I have the same problem. I have try 3 runs and got the average result 82.50. Besides, when I test the model you released, I got the same results you reported in art, sketch, photo. But my cartoon result is 76.75, and your report is 81.61. The environment and seed are the same of yours.@Justinhzy

@Justinhzy
Copy link
Collaborator

@gscahhh
Hi, do you use the exact same environment? if you use a different type of GPU or seed, the performance will definitely change and you need to tune the hyper-parameter a little bit. Please see more details in the updated notice.
I will check the cartoon resnet model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants