Skip to content
This repository has been archived by the owner on Jun 2, 2022. It is now read-only.

Support Huge Image Conversion #158

Merged
merged 71 commits into from
May 23, 2019
Merged

Support Huge Image Conversion #158

merged 71 commits into from
May 23, 2019

Conversation

YukihoAA
Copy link
Collaborator

@YukihoAA YukihoAA commented May 11, 2019 •
edited
Loading

This PR will fix #122, closes #157

w2x works like this.

  1. denoise
  2. Get minimum 2^n scale that is bigger then input scale factor.
  3. resize to 2^n scale.
  4. down scale to input scale factor.

I added 2-1. step to prevent memory fault and wrong resizing.

  1. denoise
  2. Get minimum 2^n scale that is bigger then input scale factor.
  3. resize to 2^n scale.

2-1. slice in to 4^n pieces if input image is too big to convert.

  1. down scale to input scale factor.

DeadSix27 and others added 30 commits May 7, 2019 09:10
@DeadSix27
honor enable_log when merging/slicing
85d1507
@DeadSix27
slight rephrase of merge-log
ee3c90c
@YukihoAA
bug fix with scale_ratio
f9cf725
@YukihoAA
add writing image log
a27c0b1
@YukihoAA
minor fix
bc8e598
@YukihoAA
tmp off annoying texts
ae1791a
@YukihoAA
print all of debug things
11db52c
@YukihoAA
set limit to 10000^2
42e2c15 
in 32bit apng, the limit is 11XXX or something.

i calcuated limit as 24bit png but

It was not compatible with alpha channel.
@YukihoAA
It is hard to debug too
aac050c
@YukihoAA
edit test output
fb5679e
@DeadSix27
add slice process log during silent mode (DEBUG, revert before merge)
0b14c32
@YukihoAA
for time check debug
9020e2b
@YukihoAA
Add padding to slices
97b3d5e 
will make 20px padding to each pieces
@YukihoAA
changed limit to 8000
0e03361
@YukihoAA
use max_scale_ratio rather than scale
b25ab81
@YukihoAA
[TEST] heap 200MB
27dede5
@YukihoAA
[TEST] same to main
4c1502b
@YukihoAA
STACK 2GB
536ca2b 
it works???
@YukihoAA
Revert "STACK 2GB"
ca40bff 
This reverts commit 536ca2b.
@YukihoAA
Revert "[TEST] same to main"
31c9f45 
This reverts commit 4c1502b.
@YukihoAA
Revert "[TEST] heap 200MB"
04b642c 
This reverts commit 27dede5.
@YukihoAA
[TEST] test imwrite vector
62502d6
@YukihoAA
Revert "[TEST] test imwrite vector"
88086d4 
This reverts commit 62502d6.
@YukihoAA
will fix stack smashing
cada9f6
@YukihoAA
refine test codes
939882f
@YukihoAA
Merge branch 'master' into limit_input_size
4c867dc
@YukihoAA
add free memory
23d609b
@YukihoAA
edit some comments
847ee72
@YukihoAA
add comments
efbc99b
@YukihoAA
edit debug code
f471043
@YukihoAA YukihoAA changed the title Slicing when limit Support Huge Image Conversion May 11, 2019
@YukihoAA YukihoAA requested a review from DeadSix27 May 11, 2019 14:13
@YukihoAA
minor improvement
95f92a1 
It actually not happens in my test case but just for safety
@YukihoAA YukihoAA mentioned this pull request May 20, 2019
Merged
@DeadSix27 DeadSix27 mentioned this pull request May 20, 2019
Merged
DeadSix27
DeadSix27 approved these changes May 21, 2019
View reviewed changes
Copy link
Owner

@DeadSix27 DeadSix27 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to merge #157, #158, #163 and #164 right after this one!! (confusingly many PRs)

#164 will require separate review by you @YukihoAA.

Works fine up until 17k * 17k, everything above crashes silently for me.
Due to it exceeding my memory limit of 16G.

(Still requires a proper error (somehow)))

@YukihoAA YukihoAA merged commit 4aedbd7 into master May 23, 2019
@YukihoAA YukihoAA deleted the slicing_when_limit branch May 23, 2019 12:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DeadSix27 DeadSix27 DeadSix27 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upscaling very large images got crashed result
2 participants
@YukihoAA @DeadSix27