Skip to content
This repository has been archived by the owner on Jun 2, 2022. It is now read-only.

add missing png chunk checks #168

Merged
merged 3 commits into from
Jun 22, 2019
Merged

add missing png chunk checks #168

merged 3 commits into from
Jun 22, 2019

Conversation

DeadSix27
Copy link
Owner

@DeadSix27 DeadSix27 commented May 23, 2019 •
edited
Loading

  • Add other chunk types that I have forgotten in the previous PR.
  • Also check on 4bit indexed pngs for the tRNS chunk

Now works fine:
image

@DeadSix27
w2xconv: add missing png chunk checks
72774f2 
- Add other chunk types that I have forgotton in the previous PR.
- Also check on 4bit indexed pngs for the tRNS chunk
@DeadSix27 DeadSix27 requested a review from YukihoAA May 23, 2019 15:39
@DeadSix27
dev_tools/create_test_pngs: fix incorrect bit-names
4fabf35 
a tRNS chunk doubles it..
@DeadSix27
w2xconv: remove ignore signatures that we actually need
a33cce9 
Accidentally added those to the ignore list too, but would've worked either way due to the order they're checked in.
@DeadSix27 DeadSix27 mentioned this pull request May 24, 2019
Merged
@YukihoAA YukihoAA merged commit f801647 into master Jun 22, 2019
@YukihoAA YukihoAA deleted the missing_alpha_check branch June 26, 2019 11:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@YukihoAA YukihoAA YukihoAA approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DeadSix27 @YukihoAA