Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to DIY-Flow-Bench.ino and calibration.cpp #214

Closed
wants to merge 3 commits into from
Closed

Updates to DIY-Flow-Bench.ino and calibration.cpp #214

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
abfca52
Update calibration.cpp
KirikauKiwi Nov 10, 2024
0e473d6
Update DIY-Flow-Bench.ino
KirikauKiwi Nov 10, 2024
cb1fa19
Merge branch 'DeeEmm:master' into master
KirikauKiwi Nov 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ESP32/DIY-Flow-Bench/calibration.cpp
View file
Open in desktop
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not work

Previously we created a differential that we apply as an offset to all readings

sensorVal.FlowCFM - config.cal_flow_rate
actual flow - target flow 
14cfm - 14.7cfm = -0.7cfm

now we have

actual flow + target flow 
14cfm + 14.7cfm = 28.7cfm

Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ bool Calibration::setFlowOffset() {
Messages _message;

// update config var
calVal.flow_offset = sensorVal.FlowCFM - config.cal_flow_rate;
calVal.flow_offset = sensorVal.FlowCFM + config.cal_flow_rate;

_message.debugPrintf("Calibration::setFlowOffset $ \n", calVal.flow_offset);

Expand Down