[Embedding] Fix set initialized flag too early in restore subgraph. #920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lixy9474
force-pushed
the
fix_restore
branch
2 times, most recently
from
50d11d1
to
27edef2
Compare
candyzone
reviewed
Aug 7, 2023
| OP_REQUIRES_OK(c, c->GetAttr("initial_num_buckets", &initial_num_buckets)); | ||
| is_set_initialized_ = true; | ||
| if (initial_num_buckets == embedding::IsSetInitialized::NOT_SET_INITAILIZED) | ||
| is_set_initialized_ = false; |
| @@ -406,7 +413,7 @@ class InitializeKvVariableOp : public OpKernel { | |||
| core::ScopedUnref unref_me(primary_variable); | |||
| } | |||
| core::ScopedUnref unref_me(ev); | |||
| if (steps_to_live_ != kEmbeddingVarUseDB) { | |||
| if (is_set_initialized_) { | |||
There was a problem hiding this comment.
这个可以参考代码276行，可以保持一致。
candyzone
changed the title
lixy9474
force-pushed
the
fix_restore
branch
2 times, most recently
from
397ecf9
to
e0b9a85
Compare
Signed-off-by: lixy9474 <[email protected]>
candyzone
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.