Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xrm - Updated Paths of files to match standards #13634

Merged
1 commit merged into from
Jan 6, 2017
Merged

Xrm - Updated Paths of files to match standards #13634

1 commit merged into from
Jan 6, 2017

Conversation

daryllabar
Copy link
Contributor

microsoft/types-publisher#3

Please fill in this template.

  • Make your PR against the master branch.
  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run tsc without errors.
  • Run npm run lint package-name if a tslint.json is present.

Select one of these and delete the others:

If adding a new definition:

  • The package does not provide its own types, and you can not add them.
  • If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.
  • Create it with npm run new-package package-name, not by basing it on an existing project.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • Increase the version number in the header if appropriate.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "../tslint.json" }.

If removing a declaration:

  • If a package was never on DefinitelyTyped, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • Delete the package's directory.
  • Add it to notNeededPackages.json.

@dt-bot
Copy link
Member

dt-bot commented Dec 30, 2016

xrm/v6/index.d.ts

unknown status: renamed


xrm/v7.1/index.d.ts

unknown status: renamed


xrm/v7/index.d.ts

unknown status: renamed

@ghost
Copy link

ghost commented Dec 30, 2016

I don't think it's a good idea to reference ../parature.d.ts in the older versions -- what if it changes in a newer version?
Also, do we need both 7.0 and 7.1? Can't 7.0 users use the 7.1 typings?

@daryllabar
Copy link
Contributor Author

That makes sense. I'm just not sure if parature changes in each version of the product.

The 7.1 version of CRM includes alot of functionality for grids that is not in 7.0, so they could reference something that doesn't exist. Also, the 7.1 update is not required for on premise, there will be people that don't upgrade off of 7.0 for some time. Because of that, I would think we need different versions.

@ghost ghost merged commit b671146 into DefinitelyTyped:master Jan 6, 2017
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants