-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[react-native-vector-icons] Exposed Icon methods #27444
[react-native-vector-icons] Exposed Icon methods #27444
Conversation
- Exposes methods implemented in: oblador/react-native-vector-icons#762
@SudoPlz Thank you for submitting this PR! 🔔 @iRoachie @timwangdev - please review this PR in the next few days. Be sure to explicitly select If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SudoPlz I can't merge this until that PRs been accepted. Just ping me and let me know. You would also need to bump the version when it's released
Ok, I'll ping you when the PR get's merged @iRoachie Thanks for taking a look |
@SudoPlz One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits or comments. Thank you! |
Ok, the PR is merged @iRoachie can you merge now? |
Waiting until he cuts a version. |
@SudoPlz I haven't seen anything from you in a while and this PR currently has problems that prevent it from being merged. The PR will be closed tomorrow if there aren't new commits to fix the issues. |
pff.. |
Lol i'll update just so the bot doesn't close |
Aah, cool, thanks @iRoachie |
A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped! |
Don't merge: pending version release of react-native-vector-icons |
Just released as 5.0.0 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SudoPlz To keep things tidy, we have to close PRs that aren't mergeable but don't have activity from their author. No worries, though - please open a new PR if you'd like to continue with this change. Thank you! |
Please fill in this template.
npm test
.)npm run lint package-name
(ortsc
if notslint.json
is present).Select one of these and delete the others:
If changing an existing definition: