[node] add base64url BufferEncoding option

[ermik]

New encoding option was introduced in nodejs/node#36952 and is available since v15.7.0. It is documented on the website:
https://nodejs.org/api/buffer.html#buffer_buffers_and_character_encodings

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change.
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm test <package to test>.

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes: https://nodejs.org/api/buffer.html#buffer_buffers_and_character_encodings
• If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header. (does not)

[typescript-bot]

@ermik Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

• node on npm, on unpkg

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

Status

• ✅ No merge conflicts
• ❌ Continuous integration tests have failed
• 🕐 Only a DT maintainer can approve changes without tests

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Inactive

This PR has been inactive for 13 days.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 51452,
  "author": "ermik",
  "headCommitOid": "0df19e6f0bc2aa145cf34e4564613d17a3c0a65f",
  "lastPushDate": "2021-02-26T16:35:12.000Z",
  "lastActivityDate": "2021-03-04T18:48:29.000Z",
  "maintainerBlessed": false,
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "node",
      "kind": "edit",
      "files": [
        {
          "path": "types/node/globals.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "Microsoft",
        "DefinitelyTyped",
        "jkomyno",
        "alvis",
        "r3nya",
        "btoueg",
        "brunoscheufler",
        "smac89",
        "touffy",
        "DeividasBakanas",
        "eyqs",
        "Hannes-Magnusson-CK",
        "KSXGitHub",
        "hoo29",
        "kjin",
        "ajafff",
        "islishude",
        "mwiktorczyk",
        "mohsen1",
        "n-e",
        "galkin",
        "parambirs",
        "eps1lon",
        "SimonSchick",
        "ThomasdenH",
        "WilcoBakker",
        "wwwy3y3",
        "samuela",
        "kuehlein",
        "bhongy",
        "chyzwar",
        "trivikr",
        "nguymin4",
        "yoursunny",
        "qwelias",
        "ExE-Boss",
        "Ryan-Willpower",
        "peterblazejewicz",
        "addaleax",
        "JasonHK",
        "victorperin",
        "ZYSzys"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "changereq",
      "reviewer": "SimonSchick",
      "date": "2021-03-04T06:59:37.000Z"
    }
  ],
  "ciResult": "fail",
  "ciUrl": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/0df19e6f0bc2aa145cf34e4564613d17a3c0a65f/checks?check_suite_id=2133364364"
}

[typescript-bot]

🔔 @microsoft @DefinitelyTyped @jkomyno @alvis @r3nya @btoueg @BrunoScheufler @smac89 @Touffy @DeividasBakanas @eyqs @Hannes-Magnusson-CK @KSXGitHub @hoo29 @kjin @ajafff @islishude @mwiktorczyk @mohsen1 @n-e @galkin @parambirs @eps1lon @SimonSchick @ThomasdenH @WilcoBakker @wwwy3y3 @samuela @kuehlein @bhongy @chyzwar @trivikr @nguymin4 @yoursunny @qwelias @ExE-Boss @Ryan-Willpower @peterblazejewicz @addaleax @JasonHK @victorperin @ZYSzys — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[ermik]

Happy to add tests if requested. Have not deemed them needed, but also did not see any existing tests for this feature. Also please let me know if CLA is needed for this. Thanks everybody.

[typescript-bot]

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊

	master	#51452	diff
Batch compilation
Memory usage (MiB)	124.9	126.1	+1.0%
Type count	22835	22837	0%
Assignability cache size	7594	7596	0%
Language service
Samples taken	28	28	0%
Identifiers in tests	28	28	0%
getCompletionsAtPosition
Mean duration (ms)	742.5	738.2	-0.6%
Mean CV	12.0%	10.0%
Worst duration (ms)	854.6	819.2	-4.1%
Worst identifier	start	importObject
getQuickInfoAtPosition
Mean duration (ms)	731.9	738.2	+0.9%
Mean CV	9.8%	9.8%
Worst duration (ms)	826.6	855.7	+3.5%
Worst identifier	start	start

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

[typescript-bot]

@ermik The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

[ermik]

bent, cheerio, and mongoose had test failures. After a cursory review I see no impact this PR could have on those failures. Let me know what I can do to assist.

[SimonSchick]

Missing test(s).

[typescript-bot]

@ermik One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!

[ermik]

Wow.

[peterblazejewicz]

Happy to add tests if requested. Have not deemed them needed, but also did not see any existing tests for this feature. Also please let me know if CLA is needed for this. Thanks everybody.

nothing like that, but you're changing Node types, would be more than a nice addition,and this is promoted via self-merge option after maintainer approval, so classic win-win scenario