Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@babel/core: add loadPartialConfigAsync #51741

Merged
merged 2 commits into from
Mar 15, 2021

Conversation

SimenB
Copy link
Contributor

@SimenB SimenB commented Mar 14, 2021

Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:

@typescript-bot
Copy link
Contributor

typescript-bot commented Mar 14, 2021

@SimenB Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 Most recent commit is approved by a DT maintainer

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 51741,
  "author": "SimenB",
  "headCommitOid": "5d5385a32a101e7974058320685dcb5761e8881c",
  "lastPushDate": "2021-03-14T12:08:58.000Z",
  "lastActivityDate": "2021-03-14T12:33:37.000Z",
  "maintainerBlessed": false,
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "babel__core",
      "kind": "edit",
      "files": [
        {
          "path": "types/babel__core/babel__core-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/babel__core/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "yortus",
        "marvinhagemeister",
        "mgroenhoff",
        "Jessidhia",
        "ifiokjr"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "marvinhagemeister",
      "date": "2021-03-14T12:33:37.000Z",
      "isMaintainer": false
    }
  ],
  "ciResult": "pass"
}

@typescript-bot
Copy link
Contributor

🔔 @yortus @marvinhagemeister @mgroenhoff @Jessidhia @ifiokjr — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot
Copy link
Contributor

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊
master #51741 diff
Batch compilation
Memory usage (MiB) 99.1 100.1 +1.0%
Type count 13579 13580 0%
Assignability cache size 181463 181463 0%
Language service
Samples taken 235 235 0%
Identifiers in tests 235 235 0%
getCompletionsAtPosition
    Mean duration (ms) 122.3 122.4 +0.1%
    Mean CV 15.1% 14.7%
    Worst duration (ms) 164.7 162.2 -1.5%
    Worst identifier sourceCode body
getQuickInfoAtPosition
    Mean duration (ms) 125.8 125.4 -0.3%
    Mean CV 12.8% 12.0%
    Worst duration (ms) 173.3 169.9 -1.9%
    Worst identifier map body

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

@typescript-bot typescript-bot added the Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. label Mar 14, 2021
@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label Mar 14, 2021
@typescript-bot typescript-bot removed Owner Approved A listed owner of this package signed off on the pull request. Untested Change This PR does not touch tests labels Mar 14, 2021
@typescript-bot
Copy link
Contributor

@marvinhagemeister Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label Mar 14, 2021
@weswigham weswigham merged commit a072046 into DefinitelyTyped:master Mar 15, 2021
@typescript-bot
Copy link
Contributor

I just published @types/[email protected] to npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Critical package Owner Approved A listed owner of this package signed off on the pull request. Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants