Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed lack of audience property in SignInOptions type for auth0 #58449

Merged
merged 1 commit into from
Jan 28, 2022

Conversation

maxism
Copy link

@maxism maxism commented Jan 26, 2022

Please fill in this template.

Select one of these and delete the others:
If changing an existing definition:

@typescript-bot
Copy link
Contributor

typescript-bot commented Jan 26, 2022

@maxism Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 58449,
  "author": "maxism",
  "headCommitOid": "5ca0c11e11eb5e5148b4c99f8eafb2d6f3f4784f",
  "mergeBaseOid": "3fb0662853a1ddd8247ef1eac596d660e027d254",
  "lastPushDate": "2022-01-26T13:03:52.000Z",
  "lastActivityDate": "2022-01-28T04:08:34.000Z",
  "mergeOfferDate": "2022-01-27T20:20:08.000Z",
  "mergeRequestDate": "2022-01-28T04:08:34.000Z",
  "mergeRequestUser": "maxism",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "auth0",
      "kind": "edit",
      "files": [
        {
          "path": "types/auth0/auth0-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/auth0/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "westy92",
        "ianhowe76",
        "dancrumb",
        "pwrnrd",
        "CatGuardian",
        "MengRS",
        "Scoup",
        "isabela-morais",
        "rbutera",
        "peterblazejewicz",
        "danursin",
        "nhardy",
        "robotastronaut"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "peterblazejewicz",
      "date": "2022-01-27T20:19:26.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 1022188327,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added the Popular package This PR affects a popular package (as counted by NPM download counts). label Jan 26, 2022
@typescript-bot
Copy link
Contributor

🔔 @westy92 @ianhowe76 @dancrumb @pwrnrd @CatGuardian @MengRS @Scoup @isabela-morais @rbutera @peterblazejewicz @danursin @nhardy @robotastronaut — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@peterblazejewicz
Copy link
Member

Is this for this particular part of API?
https://auth0.github.io/node-auth0/PasswordlessAuthenticator.html#signIn

@maxism
Copy link
Author

maxism commented Jan 27, 2022

Is this for this particular part of API? https://auth0.github.io/node-auth0/PasswordlessAuthenticator.html#signIn

Yes, it is. I also prepared PR to change this part of the node-auth0 documentation. I think type definitions and documentation are not tied up in each other, because users can already use this type of functionality in the lib.

Copy link
Member

@peterblazejewicz peterblazejewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@maxism thx!

@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Jan 27, 2022
@typescript-bot
Copy link
Contributor

@maxism: Everything looks good here. I am ready to merge this PR (at 5ca0c11) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@westy92, @ianhowe76, @dancrumb, @pwrnrd, @CatGuardian, @MengRS, @Scoup, @isabela-morais, @rbutera, @peterblazejewicz, @danursin, @nhardy, @robotastronaut: you can do this too.)

@maxism
Copy link
Author

maxism commented Jan 28, 2022

Ready to merge

@typescript-bot typescript-bot merged commit c319a1c into DefinitelyTyped:master Jan 28, 2022
martin-badin pushed a commit to martin-badin/DefinitelyTyped that referenced this pull request Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintainer Approved Popular package This PR affects a popular package (as counted by NPM download counts). Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants