This repository has been archived by the owner on Feb 18, 2022. It is now read-only.
Stop checking project URL. #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a hassle to keep up to date. It turns out to be low-value for automation, since it's better to check code as shipped on npm, not as stored on github. For that, we just need to check that a DT package name has an associated package on npm. We don't need to make sure that the github url is present too. I don't think it is that useful to people either, since they can find the homepage of the original package on npmjs.com.
|
@andrewbranch There's not much here to review, but you should be aware of the change. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a hassle to keep up to date.
It turns out to be low-value for automation, since checking the github source is less useful than the source as shipped from npm. For the latter, we just need to check that a DT package name has an associated package on npm. We don't need to make sure that the github url is present too.
I don't think it is that useful to people either, since they can find the homepage of the original package on npmjs.com.