Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use updated Dekode Coding Standards with removed Neutron Standard and latest commits from WPCS #429

Merged
merged 3 commits into from
Dec 12, 2022

Conversation

stian-overasen
Copy link
Member

@stian-overasen stian-overasen commented Dec 6, 2022

Heads up; Dekode Coding Standards 5.0.0 requires minimum-stability to be set to dev as we're following the develop branch from WPCS.

Correspond with this PR in Coding Standards: DekodeInteraktiv/coding-standards#27

Related thread: WordPress/WordPress-Coding-Standards#2070

@stian-overasen stian-overasen changed the title WIP: Updated Dekode Coding Standards; Use latest WPCS Use updated Dekode Coding Standards with removed Neutron Standard and latest commits from WPCS Dec 6, 2022
@stian-overasen stian-overasen marked this pull request as ready for review December 6, 2022 10:02
@stian-overasen stian-overasen assigned walbo and PeterBooker and unassigned walbo and PeterBooker Dec 6, 2022
@PeterBooker
Copy link
Contributor

Seems like PHPCS and WPCS are in a better place with PHP 8.0+ accuracy than I thought these days, so seems worth updating now.

@PeterBooker
Copy link
Contributor

PeterBooker commented Dec 7, 2022

@stian-overasen From what @Clorith just told me it sounds like WPCS v3 is coming soon, so it might be worth waiting for that (and avoid needing to update again shortly after)?

@stian-overasen stian-overasen merged commit b6e3adc into main Dec 12, 2022
@stian-overasen stian-overasen deleted the try-latest-wpcs branch December 12, 2022 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants