Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only look at members that are ways when parsing buildings #100

Merged

Conversation

mmiller-max
Copy link
Contributor

Closes #94

@captchanjack are we losing any important information by ignoring nodes and anything else that is a member of a way here?

@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.08 ⚠️

Comparison is base (fe9ddb3) 80.10% compared to head (a887c42) 80.03%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #100      +/-   ##
==========================================
- Coverage   80.10%   80.03%   -0.08%     
==========================================
  Files          15       15              
  Lines        1141     1142       +1     
==========================================
  Hits          914      914              
- Misses        227      228       +1     
Impacted Files Coverage Δ
src/buildings.jl 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@captchanjack captchanjack merged commit c5a0b8f into DeloitteOptimalReality:master Jul 24, 2023
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

buildings_from_file: ERROR: KeyError: key 5461892572 not found
2 participants