Blob Shadows: remove WriteOnly from culling counters, refactor inters…

…ection check [#176]
Delt06 · Dec 8, 2023 · c369b20 · c369b20
1 parent 97a6ca3
commit c369b20
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/Packages/com.deltation.toon-rp/Runtime/Shadows/Blobs/Bounds2D.cs b/Packages/com.deltation.toon-rp/Runtime/Shadows/Blobs/Bounds2D.cs
@@ -65,12 +65,14 @@ public void Encapsulate(float2 point)
 
     public static class Bounds2DExtensions
     {
+        private const float IntersectionSizeTolerance = 0.001f;
+
         [BurstCompile]
         public static bool Intersects(this in Bounds2D bounds, in Bounds2D otherBounds)
         {
             float2 intersectionMin = max(bounds.Min, otherBounds.Min);
             float2 intersectionMax = min(bounds.Max, otherBounds.Max);
-            return all(intersectionMax - intersectionMin >= 0.001f);
+            return all(intersectionMax - intersectionMin >= IntersectionSizeTolerance);
         }
     }
 }
diff --git a/Packages/com.deltation.toon-rp/Runtime/Shadows/Blobs/ToonBlobShadowsCulling.cs b/Packages/com.deltation.toon-rp/Runtime/Shadows/Blobs/ToonBlobShadowsCulling.cs
@@ -13,7 +13,6 @@ public unsafe struct ToonBlobShadowsCullingJob : IJobParallelFor
         public NativeArray<CullingGroup> CullingGroups;
         [WriteOnly] [NativeDisableParallelForRestriction]
         public NativeArray<int> SharedIndices;
-        [WriteOnly]
         public NativeArray<int> SharedCounters;
 
         public Bounds2D ReceiverBounds;