-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't write keywords with a None value to the files #661
Comments
To avoid that non-research keywords are not printed to the mdu, I looked up the default values in the FM kernel code for the keywords for which HYDROLIB-core sets
filepaths (indirectly in src/dflowfm_data/unstruc_model.f90)
And some outputdirs, might be best to set the defaults as
|
Until now, I thought that if a keywords is Optional and has a None value, that HYDROLIB-core would not write these keywords to the mdu file. However, recently we have added a lot of new research keywords that are all optional and have a default value of None. It turns out that if the user uses one research keywords, then all new research keywords will be written the mdu file. This is unwanted behaviour.
We then checked the behaviour for non-research keywords and we found that there are still a lot of regular keywords that do not have a default value. That problem will be tackled in #648.
In this issue we will change that HYDROLIB-core will no longer write keywords with a None value to the MDU file. The exception is for FileModels as they can't have a default value.
The text was updated successfully, but these errors were encountered: