Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: dimr_config for parallel run is incorrect #623

Merged
merged 38 commits into from
Jun 7, 2024
Merged

Bug: dimr_config for parallel run is incorrect #623

merged 38 commits into from
Jun 7, 2024

Commits on Apr 17, 2024

  1. bug: update process on input for fmcomponent and add tests. (#562)

    @MRVermeulenDeltares
    MRVermeulenDeltares committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    e297865 View commit details
    Browse the repository at this point in the history

  2. bug: Resolve incorrect component use in test & rename variable. (#562)

    @MRVermeulenDeltares
    MRVermeulenDeltares committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    689d592 View commit details
    Browse the repository at this point in the history

  3. autoformat: isort & black

    @MRVermeulenDeltares
    MRVermeulenDeltares committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    16b9b64 View commit details
    Browse the repository at this point in the history

  4. bug: add raise valueerror on not int for process (#562)

    @MRVermeulenDeltares
    MRVermeulenDeltares committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    5deeb66 View commit details
    Browse the repository at this point in the history

  5. autoformat: isort & black

    @MRVermeulenDeltares
    MRVermeulenDeltares committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    9683baa View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. bug: add validator instead of using the ctor (#562)

    @MRVermeulenDeltares
    MRVermeulenDeltares committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    e374f81 View commit details
    Browse the repository at this point in the history

  2. autoformat: isort & black

    @MRVermeulenDeltares
    MRVermeulenDeltares committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    e2dc8fe View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. bug: update that input of zero throws exception and input of one adds… 

    … no process to the output file(#562)
    @MRVermeulenDeltares
    MRVermeulenDeltares committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    46792cd View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. bug: implement newly discussed requirements and add tests. (#562)

    @MRVermeulenDeltares
    MRVermeulenDeltares committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    07bb8e8 View commit details
    Browse the repository at this point in the history

  2. autoformat: isort & black

    @MRVermeulenDeltares
    MRVermeulenDeltares committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    a03c692 View commit details
    Browse the repository at this point in the history

  3. bug: move tests to testclass.(#562)

    @MRVermeulenDeltares
    MRVermeulenDeltares committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    0549e32 View commit details
    Browse the repository at this point in the history

  4. autoformat: isort & black

    @MRVermeulenDeltares
    MRVermeulenDeltares committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    fbb37c0 View commit details
    Browse the repository at this point in the history

  5. bug: resolve codesmell.(#562)

    @MRVermeulenDeltares
    MRVermeulenDeltares committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    3879a20 View commit details
    Browse the repository at this point in the history

  6. bug: Refactor tests. (#562)

    @MRVermeulenDeltares
    MRVermeulenDeltares committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    cc0d93e View commit details
    Browse the repository at this point in the history

  7. autoformat: isort & black

    @MRVermeulenDeltares
    MRVermeulenDeltares committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    9c99373 View commit details
    Browse the repository at this point in the history

  8. bug: add multiple fmcomponent save test (#562)

    @MRVermeulenDeltares
    MRVermeulenDeltares committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    61d50fa View commit details
    Browse the repository at this point in the history

  9. bug: Refactor dimr _save method (#562)

    @MRVermeulenDeltares
    MRVermeulenDeltares committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    8f24b09 View commit details
    Browse the repository at this point in the history

  10. autoformat: isort & black

    @MRVermeulenDeltares
    MRVermeulenDeltares committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    a45cb2f View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. bug: add support for reading process with semicolon, e.g. 0:4, assumi… 

    …ng this is the same as 0 1 2 3 4 (#562)
    @MRVermeulenDeltares
    MRVermeulenDeltares committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    a05fc37 View commit details
    Browse the repository at this point in the history

  2. autoformat: isort & black

    @MRVermeulenDeltares
    MRVermeulenDeltares committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    35adfcf View commit details
    Browse the repository at this point in the history

  3. bug: resolve codesmells, make validation alike (#562)

    @MRVermeulenDeltares
    MRVermeulenDeltares committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    e72c5ea View commit details
    Browse the repository at this point in the history

  4. autoformat: isort & black

    @MRVermeulenDeltares
    MRVermeulenDeltares committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    35f068a View commit details
    Browse the repository at this point in the history

  5. bug: update semicolon process and add tests (#562)

    @MRVermeulenDeltares
    MRVermeulenDeltares committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    b0ab381 View commit details
    Browse the repository at this point in the history

  6. bug: Resolve issue in which dimr writes None instead of leaving the p… 

    …rocess out. (#562)
    @MRVermeulenDeltares
    MRVermeulenDeltares committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    935dd2b View commit details
    Browse the repository at this point in the history

  7. autoformat: isort & black

    @MRVermeulenDeltares
    MRVermeulenDeltares committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    996ebe5 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. bug: implement review suggestion moving changes to dict to _serialize… 

    … instead of _save (#562)
    @MRVermeulenDeltares
    MRVermeulenDeltares committed May 2, 2024
    Configuration menu
    Copy the full SHA
    544bea7 View commit details
    Browse the repository at this point in the history

  2. bug: implement review suggestions (#562)

    @MRVermeulenDeltares
    MRVermeulenDeltares committed May 2, 2024
    Configuration menu
    Copy the full SHA
    5d40188 View commit details
    Browse the repository at this point in the history

  3. bug: implement review suggestion moving string validation and process… 

    …ing into _parse (#562)
    @MRVermeulenDeltares
    MRVermeulenDeltares committed May 2, 2024
    Configuration menu
    Copy the full SHA
    cd48f61 View commit details
    Browse the repository at this point in the history

  4. autoformat: isort & black

    @MRVermeulenDeltares
    MRVermeulenDeltares committed May 2, 2024
    Configuration menu
    Copy the full SHA
    37db323 View commit details
    Browse the repository at this point in the history

  5. bug: implement review suggestions renaming private methods. (#562)

    @MRVermeulenDeltares
    MRVermeulenDeltares committed May 2, 2024
    Configuration menu
    Copy the full SHA
    ac0086a View commit details
    Browse the repository at this point in the history

  6. bug: update method to private method (#562)

    @MRVermeulenDeltares
    MRVermeulenDeltares committed May 2, 2024
    Configuration menu
    Copy the full SHA
    e8c6ff6 View commit details
    Browse the repository at this point in the history

  7. bug: implement review suggestion add documentation for validation. (#562 

    )
    @MRVermeulenDeltares
    MRVermeulenDeltares committed May 2, 2024
    Configuration menu
    Copy the full SHA
    b185a0b View commit details
    Browse the repository at this point in the history

  8. autoformat: isort & black

    @MRVermeulenDeltares
    MRVermeulenDeltares committed May 2, 2024
    Configuration menu
    Copy the full SHA
    387bef5 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. bug: implement review suggestion renaming values to process_value. (#562 

    )
    @MRVermeulenDeltares
    MRVermeulenDeltares committed May 3, 2024
    Configuration menu
    Copy the full SHA
    af0e19d View commit details
    Browse the repository at this point in the history

  2. bug: implement review suggestions for tests. (#562)

    @MRVermeulenDeltares
    MRVermeulenDeltares committed May 3, 2024
    Configuration menu
    Copy the full SHA
    1da087c View commit details
    Browse the repository at this point in the history

  3. bug: move TestFmComponentProcess to another location and resolve smal… 

    …l discussion points. (#562)
    @MRVermeulenDeltares
    MRVermeulenDeltares committed May 3, 2024
    Configuration menu
    Copy the full SHA
    dd46168 View commit details
    Browse the repository at this point in the history

  4. autoformat: isort & black

    @MRVermeulenDeltares
    MRVermeulenDeltares committed May 3, 2024
    Configuration menu
    Copy the full SHA
    db9dd5f View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2024

  1. Merge branch 'main' into bug/562-dimr_config-for-parallel-run-is-inco… 

    …rrect
    @tim-vd-aardweg
    tim-vd-aardweg authored Jun 7, 2024
    Configuration menu
    Copy the full SHA
    753a08c View commit details
    Browse the repository at this point in the history