Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Updated alias from blockFrom and blockTo to block-From and block-To #639

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

tim-vd-aardweg
Copy link
Contributor

refs: #473

Copy link

sonarcloud bot commented May 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@veenstrajelmer veenstrajelmer linked an issue Jun 4, 2024 that may be closed by this pull request
Copy link
Collaborator

@xldeltares xldeltares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes looks fine and matches with the user manual.

@xldeltares
Copy link
Collaborator

Hi @MRVermeulenDeltares , I have reviewed the PR and it looks good. I did not merge PR - just in case you have any specific procedures. Cheers, Xiaohan

@tim-vd-aardweg tim-vd-aardweg merged commit f234161 into main Jun 11, 2024
14 checks passed
@tim-vd-aardweg tim-vd-aardweg deleted the feature/473_Incorrect-blockFrom-alias branch June 11, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"blockFrom" time interpolation parameter gives error in Delft3DFM
3 participants