Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De Dommel met bergend gebied #158

Merged
merged 4 commits into from
Sep 27, 2024
Merged

De Dommel met bergend gebied #158

merged 4 commits into from
Sep 27, 2024

Conversation

DanielTollenaar
Copy link
Collaborator

@DanielTollenaar DanielTollenaar commented Sep 25, 2024

Een model van De Dommel met bergingsknopen volgens methode Vd Gaast. Resulteert in model DeDommel versie 2024.9.0, beschikbaar via: https://deltares.thegood.cloud/f/119263

fixes/updates:

@DanielTollenaar DanielTollenaar self-assigned this Sep 25, 2024
Copy link
Member

@visr visr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me overall, though I'd be good to address some of the comments first.

notebooks/de_dommel/01_fix_model_network.py Outdated Show resolved Hide resolved
notebooks/de_dommel/01_fix_model_network.py Outdated Show resolved Hide resolved
notebooks/de_dommel/05_add_berging.py Show resolved Hide resolved
notebooks/de_dommel/05_add_berging.py Show resolved Hide resolved
notebooks/de_dommel/05_add_berging.py Outdated Show resolved Hide resolved
src/ribasim_nl/ribasim_nl/__init__.py Outdated Show resolved Hide resolved
@DanielTollenaar DanielTollenaar merged commit a379f22 into main Sep 27, 2024
4 checks passed
@DanielTollenaar DanielTollenaar deleted the add_bergend branch September 27, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants