Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete alternative objective functions in allocation #1191

Closed
Jingru923 opened this issue Feb 28, 2024 · 1 comment · Fixed by #1193 or #1199
Closed

Delete alternative objective functions in allocation #1191

Jingru923 opened this issue Feb 28, 2024 · 1 comment · Fixed by #1193 or #1199
Assignees
Labels
allocation Allocation layer

Comments

@Jingru923
Copy link
Contributor

What
In allocation, solving the optimization problem means finding out the best solution that narrowing the gap between the user demand and the allocated demand. In the optimization problem, there are four type of object functions, we would like to have only linear absolute

Why
We would like our code to be simpler and more maintainable. @visr had a discussion with Ailbhe and the conclusion is that we can just keep the linear absolute object functions.

How
Disable the option for object function. Delete all the relevant part of the other 3 object function.

@github-project-automation github-project-automation bot moved this to To do in Ribasim Feb 28, 2024
@Jingru923 Jingru923 self-assigned this Feb 29, 2024
@Jingru923 Jingru923 moved this from To do to 🏗 In progress in Ribasim Feb 29, 2024
@Jingru923 Jingru923 linked a pull request Feb 29, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Ribasim Feb 29, 2024
@visr
Copy link
Member

visr commented Feb 29, 2024

Reopening since #1193 only disabled other options, we still need to delete the code and possibly refactor a bit to simplify code now that we don't support multiple choices.

@visr visr reopened this Feb 29, 2024
Jingru923 added a commit that referenced this issue Mar 5, 2024
…on and core (#1199)

Fixes #1191 
deleted all the relevant code of the Linear relative, quadratic
absolute and quadratic relative. Relevant unit tests are deleted or
modified. Updated the allocation page in documentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
allocation Allocation layer
Projects
Archived in project
2 participants