Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support missing Node and Edge names #1244

Closed
visr opened this issue Mar 13, 2024 · 0 comments · Fixed by #1260
Closed

Support missing Node and Edge names #1244

visr opened this issue Mar 13, 2024 · 0 comments · Fixed by #1260

Comments

@visr
Copy link
Member

visr commented Mar 13, 2024

Currently these are optional in the sense that we default to the empty string.
When setting up a model from QGIS it makes much more sense to use NULL instead. We should support that with Union{String, Missing}.

error maas-bommelerwaard v5

@JvanHouwelingen ran into this.
@github-project-automation github-project-automation bot moved this to To do in Ribasim Mar 13, 2024
@visr visr mentioned this issue Mar 14, 2024
Merged
visr added a commit that referenced this issue Mar 14, 2024
@visr
Stop using name in the core (#1260)
fcee471 
Fixes #1244

Having a node name in validation error messages is slightly nicer, but
we were only doing it in two places. And the ID printing of `Pump #5` is
quite nice and compact.
@github-project-automation github-project-automation bot moved this from To do to ✅ Done in Ribasim Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Ribasim
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stop using name in the core Deltares/Ribasim
1 participant
@visr