Reduce flow over TabulatedRatingCurve to 0 as downstream level exceeds upstream #1789
Labels
core
Issues related to the computational core in Julia
improvement
Improvements of the usability of existing functionality
Comments
This was referenced Sep 2, 2024
visr
added a commit
that referenced
this issue
Sep 3, 2024
#1792) Fixes #1771, the remaining part after #1788 was merged. I split out #1789 as a separate issue, though in this PR a lot of the preparatory work is already done (all changes related to TabulatedRatingCurve). This is breaking due to #1791 because of adding new optional columns. It is also breaking that TabulatedRatingCurve and Pump now only support one outflow edge. As far as I know this wasn't used anywhere though. We cannot easily support that anymore since we now look at downstream levels. Users should instead use separate Pumps or TabulatedRatingCurves, which can share the same upstream Basin, but go to different downstream nodes. I decided to start the reduction factors for reaching these limits from 2 centimeters away. There was one existing level based reduction factor, the level difference in the Outlet, which I also adjusted from 10 to 2 centimeter. I feel like 10 centimeter would be too much in areas where the level is controlled up to centimeter accuracies.
visr
added
core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Conceptually TabulatedRatingCurve was never intended as something that can pump water up against gravity.
Relates to #1771, and would best be tackled together with adding
The text was updated successfully, but these errors were encountered: