Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modeller input for allocation #656

Closed
SouthEndMusic opened this issue Oct 9, 2023 · 3 comments · Fixed by #699
Closed

Modeller input for allocation #656

SouthEndMusic opened this issue Oct 9, 2023 · 3 comments · Fixed by #699
Labels
allocation Allocation layer

Comments

@SouthEndMusic
Copy link
Collaborator

What should the input look like from the modeler to specify allocation? E.g. how are subnetworks, sources etc. specified?
@SouthEndMusic SouthEndMusic added needs-refinement Issues that are too large and need refinement allocation Allocation layer labels Oct 9, 2023
@github-project-automation github-project-automation bot moved this to To do in Ribasim Oct 9, 2023
@SnippenE
Copy link

SnippenE commented Oct 10, 2023 •
edited
Loading

Subnetworks have an ID and 1 or more sources where source is an edge. Nodes have an optional reference to a subnetwork ID. We reserve groups for different purposes.

We call this allocation sub-network. We should also add priority of sources. After first development we will specify the information that need to be added in the table-columns

@SouthEndMusic
Copy link
Collaborator Author

Priority of sources is at the level of a sub-network.

@SnippenE SnippenE removed the needs-refinement Issues that are too large and need refinement label Oct 10, 2023
@SouthEndMusic SouthEndMusic added the needs-refinement Issues that are too large and need refinement label Oct 24, 2023
@gijsber
Copy link
Contributor

gijsber commented Oct 24, 2023 •
edited by visr
Loading

add optional column to node table called: allocation_network_id (long integer)

add optional column to edge table: allocation_network_id (long integer, specifies source edge)

@SouthEndMusic SouthEndMusic mentioned this issue Oct 25, 2023
Merged
@SnippenE SnippenE moved this from To do to Sprint backlog in Ribasim Oct 26, 2023
@SnippenE SnippenE moved this from Sprint backlog to 🏗 In progress in Ribasim Oct 26, 2023
@SouthEndMusic SouthEndMusic removed the needs-refinement Issues that are too large and need refinement label Oct 27, 2023
SouthEndMusic added a commit that referenced this issue Oct 30, 2023
@SouthEndMusic @visr
Modeler allocation input (#699)
c3c69a9 
Fixes #656.

---------

Co-authored-by: Martijn Visser <[email protected]>
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Ribasim Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
allocation Allocation layer
Projects
Ribasim
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Modeler allocation input Deltares/Ribasim
3 participants
@gijsber @SouthEndMusic @SnippenE