-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add waterquality (substance/concentration) tables #1267
Conversation
There can be some bike shedding on the table names, but the tables are all required. Ideally we merge this soon, so we prevent a huge PoC merge later on, as discussed in our retro. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't had a look yet, but does this already incorporate the comments on #1125?
core/src/schema.jl
Outdated
@@ -96,6 +100,22 @@ end | |||
urban_runoff::Union{Missing, Float64} | |||
end | |||
|
|||
@version BasinBoundaryconcentrationV1 begin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BasinBoundaryConcentration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, that breaks some generation in the Julia code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@version BasinConcentrationV1 begin
node_id::Int32
time::DateTime
substance::String
basin::Union{Missing, Float64} # optional, for external calculations
drainage::Union{Missing, Float64}
precipitation::Union{Missing, Float64}
end
After an extensive discussion with @visr, we arrived at the current setup, with split out table for the basin. For generating concentrations (whether with Delwaq, internal) we need an initial state and boundary conditions. For control on concentrations, we only need a timeseries. Catering to both needs is complex and confusing, so we now decided to split them all out. The External table can be refactored into an external node once the functionality and/or internal concentration calculations are there. |
Fixes #1125. Split from #1137