Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor build pipeline #1645

Merged
merged 31 commits into from
Jul 29, 2024
Merged

Refactor build pipeline #1645

merged 31 commits into from
Jul 29, 2024

Conversation

Manangka
Copy link
Collaborator

@Manangka Manangka commented Jul 22, 2024

This is a major PR reafctoring the teamcity pipelines.
The goal is:

  • to avoid code duplication
  • make it easy to extend (add or remove other build steps)
  • make it more aligned with other projects (imod-python, coupler, etc)

The structure has changed slighlty
Both the windows and linux projects have a Main buildstep. This buildstep is a composite buildstep. That means that is isn't building anything directly, instead it triggers dependend buildsteps. This is the starting point of the pipeline and only this builstep is directly triggered from github

It then follows the chain and start the beginning.

Duplicate code have been extracted to Templates. The templates have been made in such a way that they can both be used by the linux build aswell as by the windows builds.

# Conflicts:
#	.teamcity/Ribasim_Linux/buildTypes/Linux_TestRibasimBinaries.kt
#	.teamcity/Ribasim_Windows/buildTypes/Windows_TestDelwaqCoupling.kt
@Manangka Manangka marked this pull request as ready for review July 26, 2024 10:18
# Conflicts:
#	.teamcity/Ribasim_Windows/buildTypes/Windows_TestDelwaqCoupling.kt
@Jingru923 Jingru923 merged commit 3969f34 into main Jul 29, 2024
8 of 9 checks passed
@Jingru923 Jingru923 deleted the refactor_build_pipeline branch July 29, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants