Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix development tools #1670

Merged
merged 4 commits into from
Jul 31, 2024
Merged

Fix development tools #1670

merged 4 commits into from
Jul 31, 2024

Conversation

deltamarnix
Copy link
Contributor

@deltamarnix deltamarnix commented Jul 31, 2024

  • Restore open-vscode.bat to use with Quarto and Julia
  • Fix mypy paths for qgis
  • Insert new line on save

@deltamarnix deltamarnix requested a review from visr July 31, 2024 11:58
Copy link
Member

@visr visr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks! Looking at the changes in the lock file, this downgrades a lot of packages, e.g. numpy back to 1, pyarrow back to 14. I guess that is all because the QGIS LTR build is not compatible with those yet? I do hope that new LTR builds will fix this because otherwise we won't know when new downstream packages break Ribasim Python. We can also consider therefore sticking with the latest QGIS release in dev, and perhaps testing LTR separately.

@deltamarnix
Copy link
Contributor Author

This looks good, thanks! Looking at the changes in the lock file, this downgrades a lot of packages, e.g. numpy back to 1, pyarrow back to 14. I guess that is all because the QGIS LTR build is not compatible with those yet? I do hope that new LTR builds will fix this because otherwise we won't know when new downstream packages break Ribasim Python. We can also consider therefore sticking with the latest QGIS release in dev, and perhaps testing LTR separately.

If that is the case, maybe it's better to resolve them in separate environments. Developing QGIS is different than developing Ribasim python. It will even make us use a different python version for that specific piece of code, right?

@visr
Copy link
Member

visr commented Jul 31, 2024

Yeah perhaps a separate environment would be better. I didn't check the python version in this lockfile, but the conda-forge QGIS builds do allow a much newer Python compared to the qgis.org builds.

@deltamarnix
Copy link
Contributor Author

@visr I have removed the QGIS fixation, as QGIS tests and Delwaq tests were failing.

@visr visr merged commit 1a8adfd into main Jul 31, 2024
28 of 29 checks passed
@visr visr deleted the fix/dev-tools branch July 31, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants