Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_value_ptr("basin.subgrid_level") now return non-nan values #1671

Merged
merged 1 commit into from
Jul 31, 2024
Merged

get_value_ptr("basin.subgrid_level") now return non-nan values #1671

merged 1 commit into from
Jul 31, 2024

Conversation

Jingru923
Copy link
Contributor

Fixes #1666

@Jingru923 Jingru923 linked an issue Jul 31, 2024 that may be closed by this pull request
Cannot get libribasim.get_value_ptr("basin.subgrid_level") to return anything other than nans #1666
Closed
visr
visr approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@visr visr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@visr visr merged commit 440f8f1 into main Jul 31, 2024
27 of 29 checks passed
@visr visr deleted the subgrid-nan branch July 31, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SouthEndMusic SouthEndMusic SouthEndMusic approved these changes

@visr visr visr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot get libribasim.get_value_ptr("basin.subgrid_level") to return anything other than nans
3 participants
@Jingru923 @visr @SouthEndMusic