Regression tests for ODE solver and integration tests for production model is in place #1695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2831d9f.
|
Take note of your revert merge commit, you should eventually merge main again and make sure that any conflicts are resolved by using --theirs (as this PR now proposes to undo commits present in the main branch). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #462
Fixes #1412
At some points, both issues are depending on the MiniO bucket. And I would like to try to set up the TC as fur as I can during the waiting time. So two issues will be closed at the same time by this PR.
This PR has a working regression test for ODE solver, and a integration test for HWS model.
For the regression tests, only 4 models was chosen for regression testing. In
trivialmodel, because it is a very simple model, all the solvers are tested under 4 different settings of autodiff and sparsity. No arrow file was used for benchmarking thetrivialmodel because it has only one basin, and the results from different settings/solvers doesn't vary much. For other 3 models, only the default solver was tested. It is tested under 4 settings of autodiff and sparsity. The benchmark arrow files will be in MiniO bucket instead of repository.For integration test, the benchmark arrow file for HWS model will be in MiniO bucket as well.
Now if you enter
pixi run test-ribasim-regressionin terminal, regression tests are run. Andpixi run model-integration-test, integration test is run.@visr can you review the Julia part?
@Manangka can you review the Kotlin part?