-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use pixi to fix julia package permissions on Windows #1710
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Technically the DEPOT_PATH can also be different, but this should in practice be sufficient.
I think there could be a use case for dispatching which would also fulfill your use case. In your case, I would recommend a Python script, instead of your |
Co-authored-by: Martijn Visser <[email protected]>
Thanks, I will make an issue.
I considered this, but I disliked the extra script and the layer of indirection. |
@evetion turns out platform specific tasks is already a thing: https://pixi.sh/dev/reference/project_configuration/#the-target-table |
Ah great stuff! I made a PR. While I remembered there being overrides (had to use them for mac), I never connected these to tasks, and couldn't find examples in the documentation. |
instead of running it everywhere and ignoring the exit code. See #1710.
Fixes #1603
Given the recent changes in Teamcity, the original project is lost-ish https://dpcbuild.deltares.nl/buildConfiguration/Ribasim_Ribasim_Windows_FixJuliaArtifactPermissions?branch=continuous_control&buildTypeTab=overview&mode=builds? As in automatic (?), greyed-out, no build steps or builds visible. Furthermore, the new Template(s) used is/are platform-agnostic, so harder to integrate a Windows specific fix.
So the easier way is just to integrate it into pixi, and always running it at CI time, also useful when it irrevocably happens on Windows laptops. However, there seems to be no way to have platform specific tasks (@Hofer-Julian is that correct and maybe worth an issue? I know you proposed the deno shell 😉), so I now just append an
exit
, ignoring any exit code of the previous command.