Add "add icon" step to windows pipeline #1712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
visr
reviewed
Aug 12, 2024
utils/ribasimicon.ico
Outdated
There was a problem hiding this comment.
Would be better in docs\assets\ribasim.ico
|
I downloaded one of the windows build artifacts from TC, it worked: :D |
visr
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #585
It is tested on local machine. After ribasim binary is built, if you run
pixi run add-ribasim-icon, the ribasim.exe will have an ribasim icon. The image file is checked in utils/ folder. This "add icon" step is added to the windows build pipeline, it is right after the build step