Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate edges #1719

Merged
merged 5 commits into from
Aug 13, 2024
Merged

Duplicate edges #1719

merged 5 commits into from
Aug 13, 2024

Conversation

Jingru923
Copy link
Contributor

Fixes #1255
It gives an error if a duplicated edge is added. Unit test is added as well

@Jingru923 Jingru923 linked an issue Aug 13, 2024 that may be closed by this pull request
Prevent duplicate edges in Ribasim Python #1255
Closed
visr
visr approved these changes Aug 13, 2024
View reviewed changes
Copy link
Member

@visr visr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI should become green after #1717 is merged and included here.

@visr visr merged commit 1f6e238 into main Aug 13, 2024
29 checks passed
@visr visr deleted the duplicate-edges branch August 13, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@visr visr visr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prevent duplicate edges in Ribasim Python
2 participants
@Jingru923 @visr