Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interpolation documentation #1720

Merged
merged 9 commits into from
Aug 19, 2024
Merged

Interpolation documentation #1720

merged 9 commits into from
Aug 19, 2024

Conversation

SouthEndMusic
Copy link
Collaborator

Fixes #1152

@SouthEndMusic SouthEndMusic changed the title Clarify linear interpolation Interpolation documentation Aug 13, 2024
@SouthEndMusic SouthEndMusic marked this pull request as draft August 13, 2024 11:50
@SouthEndMusic SouthEndMusic marked this pull request as ready for review August 14, 2024 16:54
core/src/validation.jl Show resolved Hide resolved
Copy link
Contributor

@Jingru923 Jingru923 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new 2D basin visualization looks great!

The level to storage relationship gives the volume of water in the basin at a given level, which is given by the integral over the level to area relationship from the basin bottom to the given level:

$$
S(l) = \int_{l_0}^l A(l')\text{d}l'.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the paragraph right before 1.4.1 interpolation, the level is defined as $h$. Here $l$ is used. Do they mean different level?

@Jingru923 Jingru923 merged commit e8e235a into main Aug 19, 2024
26 of 29 checks passed
@Jingru923 Jingru923 deleted the clarify_linear_interpolation branch August 19, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation: clarify that Ribasim uses piecewise linear interpolation in many places
2 participants