Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate geometry types in Python. #1760

Merged
merged 4 commits into from
Aug 27, 2024
Merged

Validate geometry types in Python. #1760

merged 4 commits into from
Aug 27, 2024

Conversation

evetion
Copy link
Member

@evetion evetion commented Aug 26, 2024

Fixes #1730

Also small 🎁 , you can now do:
pixi run generate-testmodels basic to only generate the basic model (works in the same way as pixi run ribasim-core-testmodels basic).

@evetion evetion requested a review from visr August 26, 2024 14:13
visr
visr reviewed Aug 26, 2024
View reviewed changes
Copy link
Member

@visr visr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks good to me. Need a little test for what happens when you pass the wrong geometry type.

@visr visr added the breaking A change that breaks existing models label Aug 26, 2024
@evetion evetion requested a review from visr August 27, 2024 10:29
@visr visr merged commit 9c35260 into main Aug 27, 2024
27 of 29 checks passed
@visr visr deleted the feat/validate-geometry-types branch August 27, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@visr visr visr approved these changes

Assignees
No one assigned
Labels
breaking A change that breaks existing models
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allowed geometry types
2 participants
@evetion @visr