Don't log NaN errors and limit output to top 5 #1836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evetion
approved these changes
Sep 23, 2024
core/src/logging.jl
Outdated
Comment on lines
39
to
55
| perm = sortperm(flow_error; rev = true) | ||
| errors = Pair{Symbol, Float64}[] | ||
| error_count = 0 | ||
| max_errors = 5 | ||
| for i in perm | ||
| node_id = Symbol(id_from_state_index(p, u, i)) | ||
| error = flow_error[i] | ||
| if error < model.config.solver.reltol | ||
| # Stop reporting errors if they are too small or too many | ||
| if error < model.config.solver.reltol || error_count >= max_errors | ||
| break | ||
| end | ||
| push!(errors, node_id => error) | ||
| if isnan(error) | ||
| continue | ||
| else | ||
| push!(errors, node_id => error) | ||
| error_count += 1 | ||
| end |
There was a problem hiding this comment.
errors = Pair{Symbol, Float64}[]
error_count = 0
max_errors = 5
# Iterate over the errors in descending order
for i in sortperm(flow_error; rev = true)
node_id = Symbol(id_from_state_index(p, u, i))
error = flow_error[i]
isnan(error) && continue # nan are sorted as largest
# Stop reporting errors if they are too small or too many
if error < model.config.solver.reltol || error_count >= max_errors
break
end
push!(errors, node_id => error)
error_count += 1That makes it more readable for me.
There was a problem hiding this comment.
Maybe max errors should not be set in the function but as a constant on top of the file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1833
HWS output looks like this before, and no output after.
The
invalid_unstabletest model still logs though, as captured by tests.