Remove support for resetting cumulatives from BMI #1852
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The coupler is switching to an approach where they don't need to reset the cumulatives to 0. Since this complicated the Ribasim code, let's get rid of it.
The reason for the coupler to move away from resetting cumulatives is that this possibly broke with #1819.
The dedicated BMI arrays like
vertical_flux_bmi
anduser_demand.realized_bmi
are removed. TheBMI.get_value_ptr
now just points to the cumulative state, or if it is not a state (drainage, precipitation) tobasin.cumulative_drainage
orbasin.cumulative_precipitation
.This is breaking because I also renamed these BMI variables to be more consistent with the current code, where we use the term cumulative internally.