Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try Rodas5P as default solver #1869

Closed
wants to merge 6 commits into from
Closed

Try Rodas5P as default solver #1869

wants to merge 6 commits into from

Conversation

visr
Copy link
Member

@visr visr commented Oct 3, 2024

It runs Dommel at similar speed to QNDF, and doesn't diverge over long timespans when iterating between drainage and infiltration on the bucket test model.

HWS model is 44s with Rodas5P vs 10s QNDF. Though QNDF is known to be wrong (#1851). With QNDF I get one large leak of -632063 and several 1e-8. With Rodas5P just one of 2.5e-6. So this addresses that as well.

On top of #1868.

TODO: fix tests, look into backwater model performance

visr added a commit that referenced this pull request Oct 3, 2024
Instead of latest. All PRs made since v0.31 came out seem to have pixi environment related issues. Checking if this will fix it.

#1867 green with v0.30
#1868 red with v0.31
#1869 red with v0.31

This is the error, that somewhat randomly appears during `pixi run`

```
  × /home/runner/work/Ribasim/Ribasim/.pixi/envs/dev/lib/gcc/x86_64-conda-
  │ linux-gnu/14.1.0/libhwasan.so: No such file or directory (os error 2)
```
@visr visr mentioned this pull request Oct 3, 2024
visr added a commit that referenced this pull request Oct 3, 2024
Instead of latest. All PRs made since v0.31 came out seem to have pixi
environment related issues. Checking if this will fix it.

#1867 green with v0.30
#1868 red with v0.31
#1869 red with v0.31

This is the error, that somewhat randomly appears during `pixi run`

```
  × /home/runner/work/Ribasim/Ribasim/.pixi/envs/dev/lib/gcc/x86_64-conda-
  │ linux-gnu/14.1.0/libhwasan.so: No such file or directory (os error 2)
```

The failing jobs share that they all run Julia code and are on Ubuntu,
although there are also Julia and Ubuntu jobs that pass.
`gcc_impl_linux-64` is a dependency of rust.
@visr
Copy link
Member Author

visr commented Oct 3, 2024

Rodas5P doesn't seem to like ManningResistance very well. The Julia tests go from 15 min to 30 min, and fail and are slow at Manning tests:

  test/run_models_test.jl                          |  137     5    142  18m28.1s
    trivial model                                  |   32           32     12.6s
    bucket model                                   |    8            8      0.5s
    leaky bucket model                             |   14     2     16     21.1s
    basic model                                    |   12           12      0.4s
    basic arrow model                              |    3            3      1.6s
    basic transient model                          |    5     1      6      0.3s
    Allocation example model                       |    3            3     20.3s
    sparse and AD/FDM jac solver options           |    9            9     55.4s
    TabulatedRatingCurve model                     |    5            5     23.7s
    Profile                                        |   12           12      0.1s
    Outlet constraints                             |    3            3     21.3s
    UserDemand                                     |    5            5     14.2s
    ManningResistance                              |    3     2      5  15m25.0s
    mean_flow                                      |   23           23     11.8s

@visr visr marked this pull request as draft October 7, 2024 19:33
@visr
Copy link
Member Author

visr commented Oct 8, 2024

Closing in favor of #1874.

@visr visr closed this Oct 8, 2024
@visr visr deleted the new-default branch October 8, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant