Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make parent relationship explicit. #847

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Make parent relationship explicit. #847

merged 1 commit into from
Nov 29, 2023

Conversation

evetion
Copy link
Member

@evetion evetion commented Nov 28, 2023

Fixes #811

More groundwork for #760, as doing model.node.add(), requires accessing the node._parent.network.

@evetion evetion requested a review from Huite November 28, 2023 16:01
@visr visr merged commit 1119bf4 into main Nov 29, 2023
15 checks passed
@visr visr deleted the fix/exclude-unset branch November 29, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pydantic model_dump(exclude_unset=True, ...) causes model.write to ignore mutation
3 participants