-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
80 add option for netcdf infiltration quadtree file input #81
base: main
Are you sure you want to change the base?
80 add option for netcdf infiltration quadtree file input #81
Commits on Apr 1, 2024
-
- Make sfincs_infiltration F90 including setting Preprocess="preproce…
…ssYes" - Also in Makefile.am
Configuration menu - View commit details
-
Copy full SHA for f4a9903 - Browse repository at this point
Copy the full SHA f4a9903View commit details -
- Move all original infiltration type options to sfincs_infiltration.…
…f90 within one subroutine "read_infiltration_file_original". - Division between original/netcdf input same as for subgrid
Configuration menu - View commit details
-
Copy full SHA for 8100fb5 - Browse repository at this point
Copy the full SHA 8100fb5View commit details -
- Add option to specify a 'netinfiltrationfile'
- In sfincs_domain read either read_infiltration_file_original or read_infiltration_file_netcdf, and check whether combinations match - We use _original only for regular grid, and _netcdf only for quadtree grid
Configuration menu - View commit details
-
Copy full SHA for c844de1 - Browse repository at this point
Copy the full SHA c844de1View commit details -
- First implementation that should be able to read a netinfiltrationf…
…ile with input qinffield/scs_se/ksfield assuming inftype = 'cnb' - Reading and remapping was tested for quadtree_msk
Configuration menu - View commit details
-
Copy full SHA for 413d692 - Browse repository at this point
Copy the full SHA 413d692View commit details
Commits on Apr 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 6e8885a - Browse repository at this point
Copy the full SHA 6e8885aView commit details
Commits on Apr 4, 2024
-
- First version without previous timestep dependency
- Note ; had to change definition of gamma, so not anymore mean gamma over current and upwind point > changes gamma and thus source term and IG growth, have to check still whether that is a problem or not - todo: clean up
Configuration menu - View commit details
-
Copy full SHA for 1e4d9ec - Browse repository at this point
Copy the full SHA 1e4d9ecView commit details -
- Solved so we can use the mean gamma again, issue was het H(k) is se…
…t to 0 everytime snapwave_solver is called, so now determined again - Code can be cleaned up by doing a H inout definition probably
Configuration menu - View commit details
-
Copy full SHA for 08b91f7 - Browse repository at this point
Copy the full SHA 08b91f7View commit details -
- Bit cleanup, and move back 'Make sure DoverE is filled based on pre…
…vious ee' part - and result now only little bit different anymore, because of removal of previous loop now?
Configuration menu - View commit details
-
Copy full SHA for ef60bd1 - Browse repository at this point
Copy the full SHA ef60bd1View commit details
Commits on Apr 5, 2024
-
- Hprev should be based on full E, not ee(itheta), now result is same…
… as in paper - Thereby not using H_inc_old and H_ig_old anymore from wave heights of last time step (but implicitly we still do)
Configuration menu - View commit details
-
Copy full SHA for d577d54 - Browse repository at this point
Copy the full SHA d577d54View commit details -
- Clean up by changing H to inout, so that we don't have to determine…
… it again at the start of solve_energy_balance2Dstat - Remove Sxx outside of subroutine 'solve_energy_balance2Dstat', since that is not needed anymore
Configuration menu - View commit details
-
Copy full SHA for b24e87a - Browse repository at this point
Copy the full SHA b24e87aView commit details -
- Change water depth for warning limited depth in Herbers calculation…
… to determine Hig,0 from 10 m to 5 m
Configuration menu - View commit details
-
Copy full SHA for d5b5a63 - Browse repository at this point
Copy the full SHA d5b5a63View commit details -
- Put the whole determination of the IG source term in a new subrouti…
…ne 'determine_infragravity_source_sink_term' for clarity - Also makes it easier to experiment puting the source term determination in the ' do iter=1,niter '-loop
Configuration menu - View commit details
-
Copy full SHA for 46bdd02 - Browse repository at this point
Copy the full SHA 46bdd02View commit details
Commits on Apr 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c77075d - Browse repository at this point
Copy the full SHA c77075dView commit details -
- New implementation where IG source/sink term is first determined pr…
…ior to iteration loop, to fill 'srcsh', based on effectively incident energy from previous SnapWave timestep - Then depending on new option, 'snapwave_iterative_srcsh=1, is new default', the subroutine is called again to determine srcsh now based on just updated incident wave energy. - If nr_sweeps = 4, this is slower because subroutine 'determine_infragravity_source_sink_term' is called multiple times - But, Hm0 IG converges now immediately, instead of after a few timesteps! - However, to speed up you can with snapwave_iterative_srcsh = 0 still keep old behaviour of only using the initial filling of 'srcsh'. Depends on application whether slower convergence IG wave height is problem - TODO: check whether slower performance can still be counteracted some way
Configuration menu - View commit details
-
Copy full SHA for 43623b7 - Browse repository at this point
Copy the full SHA 43623b7View commit details -
- First significant speedup by putting ' do itheta = 1, ntheta' loop …
…inside the subroutine
Configuration menu - View commit details
-
Copy full SHA for 7f09dec - Browse repository at this point
Copy the full SHA 7f09decView commit details -
- ! Update H(k), used in subroutine to calculate relative waterdepth 'gam' > TL: this creates a variability over sweeps/iterations/timesteps since 'gam' changes every time > seems more stable not to do this - OMP loop in solver did not seem to provide speedup - OMP loop in subroutine 'determine_infragravity_source_sink_term' made things slower - Even without these 3 attempts, performance loss of more times calling subroutine 'determine_infragravity_source_sink_term' in iteration loop seems negligible for small model
Configuration menu - View commit details
-
Copy full SHA for 89eb173 - Browse repository at this point
Copy the full SHA 89eb173View commit details -
- In iteration loop, save a little bit of computation time by updatin…
…g srcsh only for the first sweep (but still every iteration)
Configuration menu - View commit details
-
Copy full SHA for c4906cb - Browse repository at this point
Copy the full SHA c4906cbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c04c50 - Browse repository at this point
Copy the full SHA 6c04c50View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0294561 - Browse repository at this point
Copy the full SHA 0294561View commit details -
Configuration menu - View commit details
-
Copy full SHA for ec6e818 - Browse repository at this point
Copy the full SHA ec6e818View commit details -
Configuration menu - View commit details
-
Copy full SHA for 04a8e61 - Browse repository at this point
Copy the full SHA 04a8e61View commit details
Commits on Apr 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d55cf87 - Browse repository at this point
Copy the full SHA d55cf87View commit details -
Configuration menu - View commit details
-
Copy full SHA for f3c6925 - Browse repository at this point
Copy the full SHA f3c6925View commit details -
Configuration menu - View commit details
-
Copy full SHA for f46e1e4 - Browse repository at this point
Copy the full SHA f46e1e4View commit details -
- Update H(k) in first sweep of first iteration, so that in first tim…
…estep we get already a good estimate of srcig and thereby Hig, and not just only conservative shoaling from the boundary - Only done once to prevent changing H(k) > and thereby gam and alphaig > every time, to prevent oscillations
Configuration menu - View commit details
-
Copy full SHA for e571ae6 - Browse repository at this point
Copy the full SHA e571ae6View commit details
Commits on Apr 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for decc4f0 - Browse repository at this point
Copy the full SHA decc4f0View commit details
Commits on Apr 25, 2024
-
- Allocate vars in sfincs_domain
- correct var names from quadtree infiltration netcdf file
Configuration menu - View commit details
-
Copy full SHA for 80651d0 - Browse repository at this point
Copy the full SHA 80651d0View commit details -
- add needed 'if (nm>0) ' checks for quadtree max output
Configuration menu - View commit details
-
Copy full SHA for 9d09a34 - Browse repository at this point
Copy the full SHA 9d09a34View commit details -
- Cumprcp is already in meterds now !? > so then no conversion from m…
…m to m needed anymore
Configuration menu - View commit details
-
Copy full SHA for e546e5f - Browse repository at this point
Copy the full SHA e546e5fView commit details -
- Fix missing point_prcp because of meteo3d that was turned to false
- fix debug mode issues with extra (nm > 0) checks
Configuration menu - View commit details
-
Copy full SHA for 0dcf919 - Browse repository at this point
Copy the full SHA 0dcf919View commit details -
Configuration menu - View commit details
-
Copy full SHA for e173662 - Browse repository at this point
Copy the full SHA e173662View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8a1020e - Browse repository at this point
Copy the full SHA 8a1020eView commit details
Commits on Apr 26, 2024
-
- Merge '82 overcome dependency snapwave ig source term on previous t…
…imestep' into '80 add option for netcdf infiltration quadtree file input'
Configuration menu - View commit details
-
Copy full SHA for f6387f0 - Browse repository at this point
Copy the full SHA f6387f0View commit details