Friction values supplied by user are ignored when using setup_channels

[rvnooyen]

Version checks

• I have checked that this issue has not already been reported.
• I have checked that this bug exists on the latest version.

Reproducible Example

The method dflowfm.setup_channels in dflowfm.py specifies

"friction_type",
"friction_value",

as allowed columns, so frictiontype and frictionvalue will be dropped silently. The routine crosssections::prepare_default_friction_and_crosssection then sets

defaults["frictiontype"] = friction_type
defaults["frictionvalue"] = friction_value

from the function parameters and at line 99 update_data_columns_attributes then adds columns "frictiontype" and "frictionvalue" which results in two different specifications. In file crosssections.py the routine set_point_crosssections passes only the fields "frictiontype" and "frictionvalue" from the frame branches on to be merged into the user supplied cross sections.

Current behaviour

Friction values supplied by user are ignored when using setup_channels

Desired behaviour

Friction values supplied by user passed on to model when using setup_channels

Additional context

No response

[veenstrajelmer]

This might be because FMModel.physics.UniFrictType was called instead of FMModel.physics.uniffricttype (mind the casing and the extra f in the keyword). This will be resolved in #139

[shartgring]

Should be fixed now!

[veenstrajelmer]

After reading the issue description again, I am not sure if the PR I mentioned solved the issue. Do you think it does?