Remove calls to the removed network._link1d2d._process() function in HYDROLIB-core

[veenstrajelmer]

Kind of request

Changing existing functionality

Enhancement Description

The private function network._link1d2d._process() was removed from hydrolib-core in Deltares/HYDROLIB-core#674 (which is included in hydrolib-core 0.8.0). The relevant properties are now directly derived from the meshkernel class instead, so updating is also not necessary anymore. Remove the two calls in hydromt_delft3dfm/workflows/mesh.py:

hydromt_delft3dfm/hydromt_delft3dfm/workflows/mesh.py

Line 409 in 32785ba

network._link1d2d._process()

hydromt_delft3dfm/hydromt_delft3dfm/workflows/mesh.py

Line 538 in 32785ba

network._link1d2d._process()

Todo:

• some fixing of the tests #129
• remove usage of private function
• we also now see "ValueError: "Link1d2d" object has no field "link1d2d""
• require hydrolib-core>=0.8.0 in pyproject.toml
• resolve new pydantic validationerror: remove locationtype for cross sections, deprecated in hydrolib-core in fix: locationtype should not be written for CrossSections or ObservationCrossSections HYDROLIB-core#683
• resolve new pydantic validationerror: FMModel.Physics.UniFrictType (Unknown keywords are detected in section: 'Physics', '['UniFrictType']' (type=value_error)), might also fix Friction values supplied by user are ignored when using setup_channels  #111
• resolve new pydantic validationerror: Unknown keywords are detected in section: 'Lateral', '['quantity']'
• resolve AssertionError: {'config.geometry.dztop': AssertionError('property types do not match'), 'config.geometry.dztopunia... in tests/test_hydromt.py::test_model_build (both models). This was also encountered in some fixing of the tests #129, but a workaround was implemented. This is not sufficient to resolve this. >> resolved by updating some mdu keywords, but preferrably do not commit this.