-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dsd 24 preparations #202
Dsd 24 preparations #202
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @shartgring
Very nice introduction example! HydroMT core or more plugins could re-use it :)
A few notes left still:
- usually the notebooks are stored on git without results so that when users download them they do not get your results in their notebooks. When building the docs, then the notebooks will be executed and the results will show. Leading to:
- you may want to integrate this notebook in the docs. You have the list of examples: docs/getting_started/example_index.rst
- and usually an extra page for example in how to build a model: docs/user_guide/dflowfm_build.rst
I did not run the notebook myself but I saw your results and there's not so muc code that can go wrong so I assume this is okay!
Good points, thanks! I will also walk with Vera through the code in a couple of minutes so that will also be a good test to see if no errors appear. I have included the new notebook in the docs and also fixed some types when doing it (as part of #198) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Quality Gate passedIssues Measures |
Issue addressed
Fixes #201
Explanation
Explain how you addressed the bug/feature request, what choices you made and why.
Checklist
main
Additional Notes (optional)
For the DSD 2024. The demo will be on Monday the 11th in the afternoon