29 adapt 2d boundary

[xldeltares]

Issue addressed

Fixes #29 #6

Explanation

Explain how you addressed the bug/feature request, what choices you made and why.

Checklist

• Updated tests or added new tests
• Branch is up to date with main
• Tests & pre-commit hooks pass
• Updated documentation if needed
• Updated changelog.rst if needed

Todo:

• add to changelog (later to avoid conflicts with main): Changed: - Setup 2D boundaries from geodatasets of line geometries. (PR #93)
• newly added _forcingmodel_to_dataarray is almost identical to _read_forcing_dataframe. Refactor code so these can be merged into a single function. This would solve sonarcloud duplication error.
• examples/dflowfm_build_local.yml and tests/data/dflowfm_build_local.yml are both updated, but not extended but overwritten, deliberate?

Additional Notes (optional)

Add any additional notes or information that may be helpful.

[sonarcloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
13 Code Smells

No Coverage information
5.7% Duplication

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

[veenstrajelmer]

Current ci test failures:

=============================================== short test summary info ===============================================
FAILED tests/test_dflowfm.py::test_setup_channels - AttributeError: 'Series' object has no attribute 'filepath'
FAILED tests/test_dflowfm.py::test_write_structures - AttributeError: 'Series' object has no attribute 'filepath'
FAILED tests/test_hydromt.py::test_model_class[piave] - IndexError: list index out of range
FAILED tests/test_hydromt.py::test_model_class[local] - AttributeError: 'Series' object has no attribute 'filepath'
FAILED tests/test_hydromt.py::test_model_build[piave] - IndexError: list index out of range
FAILED tests/test_hydromt.py::test_model_build[local] - pydantic.v1.error_wrappers.ValidationError: 1 validation error for Boundary
FAILED tests/test_workflows_mesh.py::test_hydrolib_network_from_mesh - IndexError: list index out of range
FAILED tests/test_workflows_mesh.py::test_setup_links1d2d_add_links - AttributeError: 'Series' object has no attribute 'filepath'
================================ 8 failed, 5 passed, 130 warnings in 70.01s (0:01:10) =================================

[sonarcloud]

Quality Gate failed

Failed conditions
4.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud