-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add conditional to set _mv variable to np.uint64 data type #47
Open
robgpita
wants to merge
2
commits into
Deltares:main
Choose a base branch
from
robgpita:Flwdir-uint64
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -108,13 +108,13 @@ First, clone pyflwdir's ``git`` repo and navigate into the repository: | |
$ git clone [email protected]:Deltares/pyflwdir.git | ||
$ cd pyflwdir | ||
|
||
Then, make and activate a new pyflwdir conda environment based on the environment.yml | ||
Then, make and activate a new pyflwdir conda environment based on the `environment.yml` | ||
file contained in the repository: | ||
|
||
.. code-block:: console | ||
|
||
$ conda env create -f envs/pyflwdir-dev.yml | ||
$ conda activate pyflwdir-dev | ||
$ conda env create -f environment.yml | ||
$ conda activate pyflwdir | ||
|
||
Finally, build and install PyFlwDir: | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just appears to be a dtype limitation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robgpita
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fernando-aristizabal not exactly. The dtype assigned to
self._mv
needs to be the same as the dtype foridxs.ds
. Those two dtypes need to line up, otherwise there were errors in numba code. In the downstream code, incorrect aliasing was occurring based on_mv
's dtype. This was causing a mis-match in values between_mv
and items in theidxs.ds
array, which ultimately led to the IndexErrors being thrown.In order to avoid the IndexErrors, for the large array indices case, where the
idxs.ds.dtype
is set to uint64, the dtype for_mv
needs to be set to uint64 as well.